additional language: 'adoc' (asciidoc, antora)#47
Open
andi-huber wants to merge 1 commit intonidi3:masterfrom
Open
additional language: 'adoc' (asciidoc, antora)#47andi-huber wants to merge 1 commit intonidi3:masterfrom
andi-huber wants to merge 1 commit intonidi3:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having to add languages that way is a bit unfortunate. I understand if this PR gets rejected, because
adocsimply is not a programming language technically speaking.Instead what would make this library even greater would be an option for consumers of the library to add their own languages. What comes to mind is converting the existing
Languageenum to an interface (see below). But as I fiddled a bit with the sources, even though such a change can be easily done in a couple of hours, it would break backward compatibility.Anyway thumbs up on the library!
This change is